feat: optimize apply_formatter_at_index#306
Open
BobTheBuidler wants to merge 6 commits intoethereum:mainfrom
Open
feat: optimize apply_formatter_at_index#306BobTheBuidler wants to merge 6 commits intoethereum:mainfrom
BobTheBuidler wants to merge 6 commits intoethereum:mainfrom
Conversation
BobTheBuidler
commented
May 17, 2025
| formatter: Callable[..., Any], at_index: int, value: List[Any] | ||
| ) -> Generator[List[Any], None, None]: | ||
| if at_index + 1 > len(value): | ||
| try: |
Contributor
Author
There was a problem hiding this comment.
we can do this check optimistically since we expect it to succeed most often
BobTheBuidler
commented
May 17, 2025
eth_utils/applicators.py
Outdated
|
|
||
| yield from value[:at_index] | ||
| yield formatter(item) | ||
| if remaining := value[at_index+1:]: |
Contributor
Author
There was a problem hiding this comment.
only one if check to do, everything else just flows out the way it came in
BobTheBuidler
commented
May 19, 2025
| ) from None | ||
|
|
||
| yield from value[:at_index] | ||
| yield formatter(item) |
Contributor
Author
There was a problem hiding this comment.
And then we don't need to perform any additional checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong?
Related to Issue #
Closes #
How was it fixed?
Todo:
Cute Animal Picture